Rollup of 5 pull requests #147308

matthiaskrgr · 2025-10-03T19:10:35Z

Successful merges:

only replace the intended comma in pattern suggestions #147245 (only replace the intended comma in pattern suggestions)
Add regression test for 123953 #147269 (Add regression test for 123953)
Extract common logic for iterating over features #147277 (Extract common logic for iterating over features)
Respect -Z unstable options in rustdoc --test #147292 (Respect -Z unstable options in rustdoc --test)
Add xtensa arch to object file creation #147300 (Add xtensa arch to object file creation)

r? @ghost
@rustbot modify labels: rollup

…rough dyn traits

Two places doing the same thing is enough to motivate me to extract this to a method :)

…bar-not-all-in-pattern, r=lcnr only replace the intended comma in pattern suggestions Only suggest to replace the intended comma, not all bars in the pattern. Fixes rust-lang#143330. This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.

Add regression test for 123953 close: rust-lang#123953

…thar Extract common logic for iterating over features Two places doing the same thing is enough to motivate me to extract this to a method :)

…r=fmease Respect `-Z` unstable options in `rustdoc --test` This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`). In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well. Best reviewed commit by commit. Fixes rust-lang#147276 Fixes rust-lang#143930 r? fmease

Add xtensa arch to object file creation Just something that was missed in the xtensa target PRs.

matthiaskrgr · 2025-10-03T19:10:53Z

@bors r+ rollup=never p=5

bors · 2025-10-03T19:10:56Z

📌 Commit 30442dc has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-10-03T21:27:11Z

⌛ Testing commit 30442dc with merge f4babc6...

Rollup of 5 pull requests Successful merges: - #147245 (only replace the intended comma in pattern suggestions) - #147269 (Add regression test for 123953) - #147277 (Extract common logic for iterating over features) - #147292 (Respect `-Z` unstable options in `rustdoc --test`) - #147300 (Add xtensa arch to object file creation) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-10-03T23:41:38Z

The job x86_64-msvc-ext1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
 Downloading crates ...
  Downloaded bar v1.0.0 (registry `dummy-registry`)
   Compiling bar v1.0.0
   Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s

stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt

bors · 2025-10-03T23:42:05Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-10-04T06:05:23Z

@bors retry

bors · 2025-10-04T06:20:02Z

⌛ Testing commit 30442dc with merge a0f398e...

jieyouxu · 2025-10-04T07:11:05Z

msvc failure is tracked in #147321

bors · 2025-10-04T09:29:49Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a0f398e to master...

rust-timer · 2025-10-04T09:31:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147245	only replace the intended comma in pattern suggestions	`823632bbfbb2941cdc3c69130f19b39ea565a7aa` (link)
#147269	Add regression test for 123953	`e6d43ed4b0f2576be199aef09c60fa1cb7bbab03` (link)
#147277	Extract common logic for iterating over features	`a5e9d3e62738bb76f7cf43ada29a686ba2433980` (link)
#147292	Respect `-Z` unstable options in `rustdoc --test`	`fa55f38d23003d9a2935ed235975b2e2046974ca` (link)
#147300	Add xtensa arch to object file creation	`a91ab691b96334aeb2da787f9fc3655ae4a93d7a` (link)

previous master: 7950f244e7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-04T09:33:07Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)

Test differences

Show 36 test diffs

Stage 1

[ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
[ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
[ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
[ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
[ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
[ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
[ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
[ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
[ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
armhf-gnu: 4770.2s -> 5198.8s (9.0%)
dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
dist-apple-various: 3708.7s -> 3490.6s (-5.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-04T10:40:52Z

Finished benchmarking commit (a0f398e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.8%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)

A4-Tacks and others added 16 commits October 1, 2025 22:45

Fix diagnostics str::replace comma to bar

4735c21

bless tests

a08228d

regression test

934ad74

fix wording; we're replacing coma with a bar

5a8f963

bring back plural 'alternatives' in suggestion message

d1d7b94

test: Add regression test for ICE when projecting associated types th…

fab9906

…rough dyn traits

Extract common logic for iterating over features

a5c9030

Two places doing the same thing is enough to motivate me to extract this to a method :)

Respect -Z unstable options in rustdoc --test

3d5f54a

Respect --error-format in rustdoc --test

e914a1a

Add regression test for -Zcrate-attr in rustdoc --test

c1443e2

Add xtensa arch to object file creation

3f9c493

Rollup merge of rust-lang#147269 - reddevilmidzy:ice-fix, r=petrochenkov

0d0b695

Add regression test for 123953 close: rust-lang#123953

Rollup merge of rust-lang#147277 - fee1-dead-contrib:featiter, r=Zala…

9e477c4

…thar Extract common logic for iterating over features Two places doing the same thing is enough to motivate me to extract this to a method :)

Rollup merge of rust-lang#147300 - esp-rs:xtensa-meta, r=saethlin

30442dc

Add xtensa arch to object file creation Just something that was missed in the xtensa target PRs.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025

Zalathar mentioned this pull request Oct 4, 2025

Rollup of 13 pull requests #147318

Closed

jieyouxu mentioned this pull request Oct 4, 2025

cargo package::reserved_windows_name test seems to be flaky #147321

Closed

This was referenced Oct 4, 2025

Rollup of 13 pull requests #147324

Closed

Rollup of 14 pull requests #147326

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2025

bors merged commit a0f398e into rust-lang:master Oct 4, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #147308

Rollup of 5 pull requests #147308

matthiaskrgr commented Oct 3, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

rust-log-analyzer commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

matthiaskrgr commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

jieyouxu commented Oct 4, 2025 •

edited

Loading

Uh oh!

bors commented Oct 4, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 4, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #147308

Rollup of 5 pull requests #147308

Conversation

matthiaskrgr commented Oct 3, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

rust-log-analyzer commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

matthiaskrgr commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

jieyouxu commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Oct 4, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 4, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Oct 3, 2025 •

edited by rustbot

Loading

jieyouxu commented Oct 4, 2025 •

edited

Loading